Fix: Close the scheduled data loader registry upon completion of request #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasankavitha
requested review from
kilink,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
srinivasankavitha
force-pushed
the
kavitha/fix-scheduled-dataloaders
branch
from
20c5c54
to
393bef2
Compare
paulbakker
approved these changes
Sep 12, 2024
kilink
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Fixes a bug introduced in the spring-graphql integration. Upon completion of request execution, the scheduled data loader registry needs to be closed. Otherwise scheduled tasks for dataloader dispatching for a request would never get cleared out.
This is the equivalent of code in the BaseQueryExecutor: https://github.com/Netflix/dgs-framework/blob/master/graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/BaseDgsQueryExecutor.kt#L132