Always ensure there is a fingerprint for each signal (#2641)

* Always ensure there is a fingerprint for each signal
Netflix · Oct 31, 2022 · b264a98 · b264a98
1 parent 9631cf8
commit b264a98
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 179 deletions.
diff --git a/src/dispatch/database/revisions/tenant/versions/2022-10-31_34aeedc9d09a.py b/src/dispatch/database/revisions/tenant/versions/2022-10-31_34aeedc9d09a.py
@@ -1,4 +1,4 @@
-"""empty message
+"""Merge revision
 
 Revision ID: 34aeedc9d09a
 Revises: 4b65941d065a, 01aa49ca0470, 3a5e776ddce4
@@ -10,8 +10,8 @@
 
 
 # revision identifiers, used by Alembic.
-revision = '34aeedc9d09a'
-down_revision = ('4b65941d065a', '01aa49ca0470', '3a5e776ddce4')
+revision = "34aeedc9d09a"
+down_revision = ("4b65941d065a", "01aa49ca0470", "3a5e776ddce4")
 branch_labels = None
 depends_on = None
 

diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py
@@ -257,6 +257,12 @@ def deduplicate(
 ) -> bool:
     """Find any matching duplication rules and match signals."""
     duplicate = False
+
+    # always fingerprint
+    fingerprint = create_instance_fingerprint(duplication_rule.tag_types, signal_instance)
+    signal_instance.fingerprint = fingerprint
+    db_session.commit()
+
     if not duplication_rule:
         return duplicate
 
@@ -281,7 +287,6 @@ def deduplicate(
         signal_instance.case_id = instances[0].case_id
         signal_instance.duplication_rule_id = duplication_rule.id
 
-    signal_instance.fingerprint = fingerprint
     db_session.commit()
     return duplicate
 

diff --git a/src/dispatch/static/dispatch/src/components/Combobox.vue b/src/dispatch/static/dispatch/src/components/Combobox.vue