Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flips the order in which we delete triggers and their associated functions #2304

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

mvilanova
Copy link
Contributor

@mvilanova mvilanova commented Jun 30, 2022

Triggers depend on functions not vice versa. Let's drop the function first before trying to drop the trigger.

@mvilanova mvilanova added the bug Something isn't working label Jun 30, 2022
@mvilanova mvilanova merged commit 19e1048 into master Jun 30, 2022
@mvilanova mvilanova deleted the bugfix/triggers branch June 30, 2022 18:44
ekmixon added a commit to ekmixon/netflix-dispatch that referenced this pull request Jun 30, 2022
#3)

Flips the order in which we delete triggers and their associated functions (Netflix#2304)

Co-authored-by: Marc Vilanova <[email protected]>
mvilanova added a commit that referenced this pull request Jul 12, 2022
mvilanova added a commit that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant