slack_menu empty tag list fix; uvloop support. #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I'll take a look at it as soon as I can. |
mvilanova
reviewed
Aug 17, 2022
src/dispatch/evergreen/scheduled.py
Outdated
| items=items, # plugin expect dicts | ||
| ) | ||
|
|
||
| # Gmail API seems to constantly throw "tenacity.RetryError: RetryError", even though the email(s) |
There was a problem hiding this comment.
Interesting... We are not experiencing the same behavior, but I'll take a look at our server logs to double check. Any useful errors in your GCP project that could shed light at what is happening?
|
Can we split this PR into two: one for the Gmail protections and another one for the Slack stuff? |
|
The Slack and str changes look good. I can merge them once the Gmail ones are moved to a separate PR. |
kishore-jalleda
changed the title
|
dropped the gmail changes from this PR. Will submit a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add uvloop support to run the async event loop; uvicorn will pick this over asyncio, if available. Not sure about others, but In my setup (ubuntu VM), not having uvloop was resulting in 8/10 calls failing (some like /dispatch-update-incident failed 10/10) to Slack's API with the 'expired_trigger_id' error. I still see that error (w/uvloop), but it is more like 1/10. Also, this is an configurable option: "--loop [auto|asyncio|uvloop] Event loop implementation. [default: auto]"
Also, including the commit from earlier today which fixes slack_menu returning empty tag list from non-incident channels. Not sure how that was missing in the master branch although.
Some minor str changes.