Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bugfix/organization switching #2599

Closed
wants to merge 2 commits into from

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Oct 13, 2022

This PR is an attempt to unify how we handle organization/user settings this will have the added benefit of making the way we switch organizations more straightforward.

The approach, in short:

  • All user settings should be contained via the user JWT token and be set during login and assigned to currentUser.
  • currentUser should include all of the user's projects and organizations. Including whether those organizations and projects are 'default' for that user and their current roles for those projects/organizations.
  • If a user wishes to update their own settings currentUser should be updated to reflect those changes.
  • All views that require access to a user's default projects/organizations should pull from the currentUser data store.

To accomplish this, we will need to:

  • Update the permissions of the user update endpoint to consider updating multiple user organizations/projects.
  • Set a default organization that can be used for default routing on the login.
  • Ensure that when a new organization is created the creator is given ownership of that organization.

Closes #2595

@kevgliss kevgliss added the bug Something isn't working label Oct 13, 2022
@lgtm-com
Copy link

lgtm-com bot commented Oct 13, 2022

This pull request introduces 2 alerts when merging 78e4ae6 into 023a1ac - view on LGTM.com

new alerts:

  • 2 for Unused import

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 3, 2022
@github-actions
Copy link
Contributor

This PR was closed, because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Dec 13, 2022
@kevgliss kevgliss deleted the bugfix/organization-switching branch January 9, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switching organization in UI is not working
1 participant