Bugfix/incident-endpoint-performance #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They query performance for /incidents is quite poor. Via nested pedantic relationships we are loading a cascading set of attributes we don't need. This PR introduced the idea of "minimal" models that try to not load any unnecessary sub-models. This along with modifying some relationships' lazy loading to use subqueries provided a 10x reduction in API response time (loading 500 incidents).
There are likely similar improvements to be back for cases and other endpoints. Should the need arise. I've removed several "nested" models that were similar to "minimal" but never actually used.