Creates a new plugin for Duo that provides on-demand MFA across Dispatch #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
commented
Mar 1, 2023
|
Chatted w/ @kevgliss about this PR, updated plugin name to |
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…tch (Netflix#3035) * initial scaffolding for duo plugin * Create example for Slack plugin * Add duo requirement * remove index-url * remove new line * Apply black formatter * add docstring * Update src/dispatch/plugins/dispatch_duo/plugin.py * Change MFA plugin type to auth-mfa and remove example
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
…tch (Netflix#3035) (#17) * initial scaffolding for duo plugin * Create example for Slack plugin * Add duo requirement * remove index-url * remove new line * Apply black formatter * add docstring * Update src/dispatch/plugins/dispatch_duo/plugin.py * Change MFA plugin type to auth-mfa and remove example Co-authored-by: Will Sheldon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new plugin for Duo that provides a push notification method that can be used across the application to gate certain functionality behind an additional MFA prompt. We also include an example Slack flow to visualize how this would work within the Slack plugin.
The example is complete and shows how we can change behavior based on the result of the Duo response. I'll remove the example if we are OK with the structure of the plugin overall.