Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormData argument is redundant in _create_snooze_filter function #3104

Merged
merged 2 commits into from
Mar 13, 2023
Merged

FormData argument is redundant in _create_snooze_filter function #3104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80381df
FormData argument is redundant in _create_snooze_filter function
wssheldon Mar 13, 2023
5799990
Merge branch 'master' into tech-debt/form-data-arg
wssheldon Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/dispatch/plugins/dispatch_slack/case/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,10 +563,10 @@ def handle_snooze_submission_event(

def _create_snooze_filter(
db_session: Session,
form_data: FormData,
subject: SubjectMetadata,
user: DispatchUser,
) -> None:
form_data: FormData = subject.form_data
# Get the existing filters for the signal
signal = signal_service.get(db_session=db_session, signal_id=subject.id)
# Create the new filter from the form data
Expand Down Expand Up @@ -620,7 +620,6 @@ def _create_snooze_filter(
if mfa_enabled is False:
_create_snooze_filter(
db_session=db_session,
form_data=context["subject"].form_data,
user=user,
subject=context["subject"],
)
Expand Down Expand Up @@ -658,7 +657,6 @@ def _create_snooze_filter(
# Get the existing filters for the signal
_create_snooze_filter(
db_session=db_session,
form_data=context["subject"].form_data,
user=user,
subject=context["subject"],
)
Expand Down