Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate signal instance messages in Case thread #3290

Merged
merged 8 commits into from
Apr 21, 2023

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Apr 21, 2023

Screenshot 2023-04-21 at 10 51 04 AM

@wssheldon wssheldon added the enhancement New feature or request label Apr 21, 2023
@wssheldon
Copy link
Contributor Author

@kevgliss The only trade-off introduced here is that we can only show 1 raw signal data (the first one) in slack now, this is OK I think. But, we could probably implement a paging functionality like the list signals modal if we wanted to be able to see them all, barring any blockkit limitations.

@wssheldon wssheldon requested a review from kevgliss April 21, 2023 17:52
@kevgliss
Copy link
Contributor

This looks good, I think there is probably a way to clean up the Seen in... language to avoid so much repetition but I can't really think of a good way right now.

@wssheldon
Copy link
Contributor Author

This looks good, I think there is probably a way to clean up the Seen in... language to avoid so much repetition but I can't really think of a good way right now.

Agreed, here's a potential alternative, although this feels worse somehow to me. 🤷‍♂️

There's probably some clever blockkit solve here.

Screenshot 2023-04-21 at 11 16 14 AM

@wssheldon
Copy link
Contributor Author

wssheldon commented Apr 21, 2023

It could be a button that just pops open a modal with this information. Or the entity value itself could be a button that when clicked opens this modal.

@kevgliss
Copy link
Contributor

Yeah, or maybe just pick the most important one? (other cases)?

@wssheldon wssheldon merged commit e18ec21 into master Apr 21, 2023
@wssheldon wssheldon deleted the enhancements/signal-instance-message branch April 21, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants