Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a signal definition to be referenced by it's external id #3646

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

kevgliss
Copy link
Contributor

@kevgliss kevgliss commented Jul 31, 2023

This allows a signal definition referenced directly by its external id. Allows for direct interaction with other integration.

We already allow signal instances to reference signal definitions by their external id. This just extends that logic to the API as well as the signal instance post body.

@kevgliss kevgliss added the enhancement New feature or request label Jul 31, 2023
@kevgliss kevgliss requested a review from wssheldon July 31, 2023 21:15
@kevgliss kevgliss merged commit 813532c into master Jul 31, 2023
8 checks passed
@kevgliss kevgliss deleted the enhancement/signal-external-id branch July 31, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants