Adds Case Page, Signal Graph, and supporting components #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wssheldon
reviewed
Nov 29, 2023
| @@ -46,7 +46,7 @@ export const publicRoute = [ | |||
| }, | |||
| { | |||
| path: "/implicit/callback", | |||
| name: "PKCEImplicityCallback", | |||
| name: "PKCEImplicitlyCallback", | |||
There was a problem hiding this comment.
Looks like linters caught a typo here. I don't know what the effect of this might be but highlighting it so we don't forget.
…nd remove future state code
wssheldon
changed the title
wssheldon
approved these changes
Nov 29, 2023
kevgliss
commented
Nov 29, 2023
| summary="Retrieves a minimal list of case participants.", | ||
| dependencies=[Depends(PermissionsDependency([CaseViewPermission]))], | ||
| ) | ||
| def get_case_participants_minimal( |
There was a problem hiding this comment.
Is the minimal here to denote we don't fetch sub objects for each participant? If so, we may want to follow a similar pattern to /cases and /incidents and return the minimal object by default and allow for the ?expand=True parameter if we need it.
src/dispatch/static/dispatch/src/participant/ParticipantAvatarGroup.vue
Outdated
Show resolved
Hide resolved
src/dispatch/static/dispatch/src/participant/ParticipantSearchPopover.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.