Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds additional bot check. #4884

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Adds additional bot check. #4884

merged 6 commits into from
Jun 26, 2024

Conversation

metroid-samus
Copy link
Contributor

Adds additional check for is_bot flag in user info

@metroid-samus metroid-samus added the bug Something isn't working label Jun 26, 2024
@metroid-samus metroid-samus self-assigned this Jun 26, 2024
jschroth
jschroth approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@jschroth jschroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trying to prevent errors when the response is not formatted the way we expect. It will still error, but it will error on the ContextError and not the None does not have...

src/dispatch/plugins/dispatch_slack/middleware.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/middleware.py Outdated Show resolved Hide resolved
src/dispatch/plugins/dispatch_slack/middleware.py Outdated Show resolved Hide resolved
@metroid-samus metroid-samus merged commit 6374d53 into master Jun 26, 2024
8 checks passed
@metroid-samus metroid-samus deleted the bugfix/user_middleware_bot_check branch June 26, 2024 20:03
metroid-samus added a commit that referenced this pull request Sep 25, 2024
@metroid-samus @jschroth
Adds additional bot check. (#4884)
d233a6d 
* Adds additional bot check.

* Fixes placement of users_info API call

* Update src/dispatch/plugins/dispatch_slack/middleware.py

Co-authored-by: Jason Schroth <[email protected]>

* Update src/dispatch/plugins/dispatch_slack/middleware.py

Co-authored-by: Jason Schroth <[email protected]>

* Update src/dispatch/plugins/dispatch_slack/middleware.py

Co-authored-by: Jason Schroth <[email protected]>

---------

Co-authored-by: Jason Schroth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschroth jschroth jschroth approved these changes

@whitdog47 whitdog47 Awaiting requested review from whitdog47

Assignees

@metroid-samus metroid-samus

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metroid-samus @jschroth