Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates the modal immediately after invocation. Update the modal with the task fields after. #5276

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

metroid-samus
Copy link
Contributor

@metroid-samus metroid-samus commented Oct 1, 2024

Contact plugin API calls may take time to run. This causes the Slack trigger to expire before the modal is loaded. This PR creates the modal immediately after the trigger and then populates the modal with the task fields after the API calls have completed.

@metroid-samus metroid-samus added the bug Something isn't working label Oct 1, 2024
@metroid-samus metroid-samus self-assigned this Oct 1, 2024
@metroid-samus metroid-samus marked this pull request as ready for review October 1, 2024 20:03
@metroid-samus metroid-samus merged commit 43758fc into master Oct 1, 2024
9 checks passed
@metroid-samus metroid-samus deleted the bugfix/handle-slow-loading-for-task-modal branch October 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants