Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(core-ticket): Add dispatch_weblink field to core ticket plugin #5377

Conversation

bashbreakpoint
Copy link
Contributor

When using the core ticket plugin, we're getting the error TypeError: DispatchTicketPlugin.update() got an unexpected keyword argument 'dispatch_weblink' This field was added for the Jira ticket plugin but never added to the core plugin. Since the plugin returns no matter the arguments, I've simply added the field.

When using the core ticket plugin, we're getting the error
`TypeError: DispatchTicketPlugin.update() got an unexpected keyword argument 'dispatch_weblink'`
This field was added for the Jira ticket plugin but never added to the
core plugin. Since the plugin returns no matter the arguments, I've simply added the field.
Copy link
Contributor

@whitdog47 whitdog47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@whitdog47 whitdog47 added the bug Something isn't working label Oct 22, 2024
@bashbreakpoint bashbreakpoint changed the title fix(core-ticket): Add dispatch_weblink field to core ticket plugin bug(core-ticket): Add dispatch_weblink field to core ticket plugin Oct 22, 2024
@bashbreakpoint
Copy link
Contributor Author

Happy to. I've got at least one other fix I can push too.

@bashbreakpoint
Copy link
Contributor Author

Apologies for the lint error. My IDE is just not set up well for python development. I'll fix that if I push anything more.

@mvilanova mvilanova merged commit 968ad5c into Netflix:master Oct 22, 2024
8 checks passed
@bashbreakpoint bashbreakpoint deleted the bugfix/basic-ticket-plugin-dispatch-weblink branch October 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants