Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

techdebt(plugin): deprecates the document resolver plugin and its code #5420

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mvilanova
Copy link
Contributor

Summary of Code Changes

incident/flows.py

  • Imports Reorganized: Cleaned up and reorganized import statements for better readability.
  • Code Removal: Removed commented-out code related to sending suggested reading messages to participants, which was previously disabled due to an issue with the Dispatch resolver plugin.

incident/messaging.py

  • Imports Reorganized: Cleaned up and reorganized import statements for better readability.
  • Function Removal: Removed the get_suggested_document_items and send_incident_suggested_reading_messages functions, which were responsible for generating and sending suggested reading messages to participants.

plugins/bases/__init__.py

  • Plugin Removal: Removed the import statement for DocumentResolverPlugin.

plugins/bases/document_resolver.py

  • File Deleted: Removed the document_resolver.py file, which contained the DocumentResolverPlugin class.

plugins/dispatch_core/config.py

  • Imports Reorganized: Cleaned up and reorganized import statements for better readability.

plugins/dispatch_core/plugin.py

  • Imports Reorganized: Cleaned up and reorganized import statements for better readability.
  • Plugin Removal: Removed the DispatchDocumentResolverPlugin class, which was responsible for resolving incident documents using Dispatch.

These changes primarily focus on cleaning up the codebase by removing unused or deprecated functionality related to document resolution and suggested reading messages, as well as improving the organization of import statements for better code readability.

Copy link
Contributor

@whitdog47 whitdog47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mvilanova mvilanova merged commit 3638445 into master Nov 1, 2024
9 checks passed
@mvilanova mvilanova deleted the techdebt/document-resolver-plugin branch November 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants