Feat/iframe visuals #120
Merged
Feat/iframe visuals #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/iframe-visuals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for a pull request
Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Description of the Change
Visual changes to hide elements when MFGUI is shown within an iframe.
Alternate Designs
One feature flag to hide all elements. I thought it was cleaner to separate the elements and have separate feature flags for each of them.
Possible Drawbacks
-
Verification Process
Set each feature flag listed in the table above and check to see if the related components are hidden.
Release Notes
Visual changes to hide elements when MFGUI is shown within an iframe, controlled by feature flags