Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use step name and task id to identify active task #136

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

obgibson
Copy link
Collaborator

@obgibson obgibson commented Feb 6, 2024

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

Tasks with duplicate names/ids were all shown as active in the task list. The change was to identify the active task by step name and id so that the key would be unique.

Alternate Designs

-

Possible Drawbacks

Duplicate step name and task id combinations

Verification Process

  • Run a flow that has duplicate task ids
  • In MFGUI, click on one of the tasks
  • You should only see one row of the task list being highlighted as active

Release Notes

Fixed bug where all tasks with the same id were shown as active in the task list

@obgibson obgibson merged commit 67589f3 into master Mar 5, 2024
3 checks passed
@obgibson obgibson deleted the bug/dup-active-tasks branch March 5, 2024 13:41
valayDave pushed a commit to valayDave/metaflow-ui that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant