libvmaf: use _XOPEN_SOURCE, not _POSIX_C_SOURCE #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Breaks Windows CI, there should be a way to fix this for both BSDs and Windows. |
On BSD operating systems (I tested FreeBSD and NetBSD), with _POSIX_C_SOURCE=200112L, M_PI (needed by src/feature/ciede.c) is not exposed. _XOPEN_SOURCE=600 exposes a superset of _POSIX_C_SOURCE=200112L, including M_PI.
alyssais
force-pushed
the
_POSIX_C_SOURCE
branch
from
bc1e0c5
to
322db8b
Compare
|
I've reworked this in a way that is hopefully more correct and less likely to break Windows. |
alyssais
changed the title
|
Merged. Thank you, Alyssa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On BSD operating systems (I tested FreeBSD and NetBSD), with _POSIX_C_SOURCE=200112L, M_PI (needed by src/feature/ciede.c) is not exposed.
_XOPEN_SOURCE=600 exposes a superset of _POSIX_C_SOURCE=200112L, including M_PI.
Description of attempt #1
On BSD operating systems (I tested FreeBSD and NetBSD), this has the effect of hiding M_PI, which is needed by src/feature/ciede.c.
A patch doing exactly this is used in FreeBSD Ports.