Implement Promtail as a new core service #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidePrincipi
force-pushed
the
promtail-merge
branch
2 times, most recently
from
3451a7e
to
091147e
Compare
Merge ns8-promtail module into the core code.
We cannot rely on local Redis replica to discover the modules installed on the local node, for two important reasons: 1. the cluster/module_node relation is not still updated when node/add-module runs. The information is missing completely; 2. even if we fix the above point and we push the information in the master Redis instance at the right time, there is no guarantee that it is replicated when node/add-modules starts `generate-promtail-config` As consequence, the list of local modules is obtained by looking at their state/ directory with filesystem-only operations. Redis is not involved in this discovery process.
Merge the environment NODE_ID with existing values, do truncate the file!
- Do not extract .gitignore file - Assume state/ dirs are created when the image is extracted
DavidePrincipi
force-pushed
the
promtail-merge
branch
from
091147e
to
c0b9b67
Compare
gsanchietti
reviewed
Aug 1, 2023
core/imageroot/var/lib/nethserver/cluster/actions/create-cluster/70start_promtail
Show resolved
Hide resolved
gsanchietti
approved these changes
Aug 1, 2023
Amygos
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the ns8-promtail rootfull core module into the core codebase.
promtail.serviceis enabled and started by the node agent increate-clusterandjoin-nodeactions.See https://trello.com/c/asPlFBiY/310-core-p1-log-relaunched-collecting-viewing