Refactor CreateOrEditTask.vue component #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
fixGhostProps
branch
2 times, most recently
from
2bbb9aa
to
df2d9d9
Compare
andre8244
reviewed
Oct 14, 2024
| @@ -241,6 +241,17 @@ export default { | |||
| loading: { | |||
| createTask: false, | |||
| }, | |||
| localuser: "", | |||
There was a problem hiding this comment.
JS variables should use camelCase, localuser and the following lines use no case or snake_case
There was a problem hiding this comment.
should be good @andre8244
stephdl
force-pushed
the
fixGhostProps
branch
from
11ef76f
to
a5b4578
Compare
stephdl
force-pushed
the
fixGhostProps
branch
from
a5b4578
to
bf52fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the CreateOrEditTask.vue component to prevent direct modification of the parent task object. Instead, local variables within the component are used for edits, and if the page is exited without saving, those values are cleared. These changes ensure the component works correctly and that the fields are reset when the modal is hidden.
NethServer/dev#7052