-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flashloan Detector 02.02 - Update #17
Conversation
…fferent end recipient
Trying to test the bot with this tx that we discussed, I get a false negative. That seems to be because, while the native profits are calculated correctly, when iterating through the back of It specifically enters the I think that's happening because the last thing happening in the transaction (which results in the profit of the attacker) is the ETH transfer in the end. A possible mitigation is to check if the last thing that happened in the transaction is an ERC20 or an ETH transfer. If it's the latter, then the bot shouldn't check the end recipient from the ERC20 transfer events. To do this, the bot could, for every |
The Balancer flashloan signature can be found in the transaction that was given as an example in the recently opened issue on this repo (tx link) This seems a simple fix, basically creating a On the same topic, there's an issue opened on our main repo, for which, while I think we don't need to change the Pancake's Large-Swap bot, we could also include that flashloan's signature to this bot as well. |
… native transfers
Transfer
event and native coin transferslabels
property to findings