-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ci #9
Merged
Merged
Feature/ci #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexb5dh
force-pushed
the
feature/ci
branch
5 times, most recently
from
February 25, 2024 16:17
0669325
to
8798cfc
Compare
alexb5dh
force-pushed
the
feature/ci
branch
2 times, most recently
from
February 26, 2024 06:45
435ea3c
to
5dd543b
Compare
samtin0x
reviewed
Feb 26, 2024
samtin0x
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, trusting you this works, code looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Changelog
Adds automatic backend deployment to AWS.
Features
npm run build
producing invalid resultts-node
(.ts) or complied and executed usingnode
(.js). This fix allows both environment to use the same database, regardless of migration files extension.knex_migrations
table manually.Notes
.env.local
and.env.dev
files.INPUT_
prefix and referenced in the.env.dev
file, for example as:DB_URI=${INPUT_DB_URI?error}
(?error
here forces Docker Compose to fail if variable is not set).