Fix CREATE/CREATE2 when account has max nonce #3698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This change is fixing 86 hive consensus tests (out of 99 failing because of CREATE/CREATE2). Constantinople is still failing. I will investigate it next week. Other test (sstoreGas_d0g0v0_Constantinople) is failing only on Constantinople too, so probably problem is in other place than related with this PR.
Types of changes
Testing
Requires testing
It's covered in hive consensus tests