Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable warning in engine_getBlobsV1 #7380

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Disable warning in engine_getBlobsV1 #7380

merged 1 commit into from
Sep 2, 2024

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Sep 2, 2024 •
edited
Loading

Fixes #7322

Changes

  • disable warning if CL doesn't have engine_getBlobsV1 as it is optional on CL side (link)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit e05f9f0 into master Sep 2, 2024
66 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/disable_warning_in_eth_getblobs branch September 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchodola kamilchodola kamilchodola approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcindsobczak @LukaszRozmej @kamilchodola