-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor TxValidator
#7386
Refactor TxValidator
#7386
Changes from 6 commits
f045e23
6eeec81
6cef6ef
a5758b8
cb523bd
f6f0c92
7d85f1e
17ff03f
37f626d
53f184c
5f5dce2
dd15a56
b416151
1a95ca6
1430dc5
750e3fa
84dce88
86bc383
1691e20
644ac9a
d4091c9
fff2f90
5e14c71
04d7fff
840d3a3
9437715
ec0d5a2
0b5d838
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -208,7 +208,7 @@ public ISealEngine SealEngine | |||
public ITxPoolInfoProvider? TxPoolInfoProvider { get; set; } | ||||
public IHealthHintService? HealthHintService { get; set; } | ||||
public IRpcCapabilitiesProvider? RpcCapabilitiesProvider { get; set; } | ||||
public ITxValidator? TxValidator { get; set; } | ||||
public TxValidator? TxValidator { get; set; } | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like this to remain an interface. Any reason not to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had to change it to a concrete class since during initialization we might want to register validators for new
|
||||
public IBlockFinalizationManager? FinalizationManager { get; set; } | ||||
public IGasLimitCalculator? GasLimitCalculator { get; set; } | ||||
|
||||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like this to remain an interface. Any reason not to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required due to the change on
NethermindApi