[WIP] Pectra eip7702 consolidations #7449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3dbb0ef)
(cherry picked from commit 419d727)
(cherry picked from commit 19f3ad5)
(cherry picked from commit 5c1e3dc)
(cherry picked from commit 0739aaa)
(cherry picked from commit bf78353)
(cherry picked from commit 6380314)
(cherry picked from commit cf58cd2)
(cherry picked from commit 7974a8b)
(cherry picked from commit 7b28007)
(cherry picked from commit 8f5c169)
(cherry picked from commit b1020eb)
(cherry picked from commit d30e193)
(cherry picked from commit 68c3736)
(cherry picked from commit d11df9c)
(cherry picked from commit b347664)
(cherry picked from commit caed2f3)
(cherry picked from commit bb7c803)
emlautarom1
reviewed
Sep 18, 2024
There was a problem hiding this comment.
- Some questions regarding checks on consolidation request lists
- Spotted an issue when compiling
Ethereum.Test.Base - Spotted an issue when serializing transaction that should not have
AuthorizationListas a field. - Also several small things (ex. unused imports and variables, empty files, magic constants, typos, etc).
There are still some things missing (ex. SetCode transaction validation) but we can already work on the above mentioned items.
Also, since the PR involves changes to the VirtualMachine code it should be thoroughly reviewed.
| public virtual bool IsEip2935Enabled => spec.IsEip2935Enabled; | ||
| public virtual bool IsEip7709Enabled => spec.IsEip7709Enabled; | ||
| public virtual Address Eip2935ContractAddress => spec.Eip2935ContractAddress; | ||
| public virtual bool IsEip6780Enabled => spec.IsEip6780Enabled; | ||
| public bool IsEip7702Enabled => spec.IsEip7702Enabled; |
There was a problem hiding this comment.
Could we have a similar issue to #7386 (comment) where we're not cascading the EIP requirements?
There was a problem hiding this comment.
Maybe we should have depency chains for EIPs in ReleaseSpec?
But i think that is outside the scope here.
@MarekM25
|
Closing in favor of #7459 |
|
My bad on this one, I missed the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't review it for now
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.