Fix AVS Details tab navigation #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenthongzy
commented
Jul 26, 2024
src/App.jsx
Outdated
Comment on lines
21
to
34
| const router = createBrowserRouter( | ||
| createRoutesFromElements( | ||
| <Route path="/" element={<Layout />}> | ||
| <Route index element={<Home />} /> | ||
| <Route path="/avs" element={<AVSList />} /> | ||
| <Route path="/avs/:address/:tab?" element={<AVSDetails />} /> | ||
| <Route path="/lrt" element={<LRT />} /> | ||
| <Route path="/operators" element={<OperatorsList />} /> | ||
| <Route path="/operators/:address" element={<OperatorDetails />} /> | ||
| <Route path="/lst" element={<LST />} /> | ||
| <Route path="*" element={<NotFound />} /> | ||
| </Route> | ||
| ) | ||
| ); |
There was a problem hiding this comment.
moved this up as per https://reactrouter.com/en/main/routers/router-provider. I need to access the router instance
|
|
||
| export default function App() { | ||
| log.debug('Starting up'); | ||
|
|
||
| return ( | ||
| <NextUIProvider> | ||
| <NextUIProvider navigate={router.navigate}> |
There was a problem hiding this comment.
So that the href in Tab can work properly. The docs say this is "PRIVATE - DO NOT USE" , but its perfectly fine to use as per the maintainer.
If we are not feeling comfortable with using this "unstable" API, we would have to remove the usage of createBrowserRouter and RouterProvider and use <BrowserRouter/> instead. From what I can tell, we don't use any of the fancy data API features provided by RouterProvider so switching should not break anything. More info here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
http://localhost:5173/avs/0x870679e138bcdf293b7ff14dd44b70fc97e12fc0/operators?page=1&sort=-tvl