Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read channel gain from .rec file in SpikeGadgetsRawIO. #1441

Closed
gkBCCN opened this issue Mar 20, 2024 · 4 comments
Closed

Read channel gain from .rec file in SpikeGadgetsRawIO. #1441

gkBCCN opened this issue Mar 20, 2024 · 4 comments
Milestone

Comments

@gkBCCN
Copy link
Contributor

gkBCCN commented Mar 20, 2024

In the doc string for this class, it says:

Notes
-----
This file format has multiple version. New versions include the gain for scaling.
The current implementation does not contain this feature because we don't have
files to test this. So now the gain is "hardcoded" to 1, and so units are
not handled correctly.

It should be possible to read these from the header and a .rec file was recently added to test this.

@zm711
Copy link
Contributor

zm711 commented Mar 20, 2024

Awesome, any interest in opening the PR for this?

@gkBCCN
Copy link
Contributor Author

gkBCCN commented Mar 20, 2024

Do you mean once I have a fix? Or preemptively?

@zm711
Copy link
Contributor

zm711 commented Mar 20, 2024

Once you have a fix. One of us will work on this when we have time, but if you have experience with the files/format it would also be great if you wanted to try to make the PR yourself. Up to you :)

@gkBCCN
Copy link
Contributor Author

gkBCCN commented Mar 20, 2024

Gladly. I'm also making changes to the probeinterface and spikeinterface packages in order to support SpikeGadgets .rec files, so maybe it makes sense for me to do the same for the neo extractor.

@zm711 zm711 added this to the 0.14.0 milestone Mar 26, 2024
gkBCCN added a commit to gkBCCN/python-neo that referenced this issue Mar 28, 2024
Updates spikegadgetsrawio.py:_parse_header() to read
the channel (ntrode) gain scaling from the header file elements.
@gkBCCN gkBCCN closed this as completed Apr 9, 2024
@zm711 zm711 modified the milestones: 0.14.0, 0.13.4 Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants