Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create neo.units module #278

Open
apdavison opened this issue Feb 3, 2017 · 2 comments · May be fixed by #1465
Open

Create neo.units module #278

apdavison opened this issue Feb 3, 2017 · 2 comments · May be fixed by #1465
Labels
Core good-for-beginners task
Milestone
future

Comments

@apdavison
Copy link
Member

As a way to start addressing #133 I suggest creating a module neo.units, which for the time being would just import all of the units from quantities, but would make it easier in future to move to pint or other library since we would avoid using the quantities (or pq) namespace.

All of the documentation, examples and docstrings should also be updated to use the new module.
@apdavison apdavison added this to the future milestone Feb 3, 2017
joffreygonin added a commit to joffreygonin/python-neo that referenced this issue Mar 13, 2017
@joffreygonin
NeuralEnsemble#278 Create neo.units module
f63d38b 
And remove Quantities import in the code (except for units module)
@joffreygonin joffreygonin mentioned this issue Mar 14, 2017
Closed
@apdavison apdavison modified the milestones: future, 0.5.2 Sep 26, 2017
@samuelgarcia samuelgarcia mentioned this issue Jun 14, 2023
Closed
@zm711
Copy link
Contributor

zm711 commented Feb 10, 2024

@apdavison, now that you are working on quantities do you still want this on the list of to-dos?

@apdavison
Copy link
Member Author

I think it's still worth doing for long-term maintainability, but it's not urgent.

@zm711 zm711 linked a pull request Apr 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core good-for-beginners task
Projects
None yet
Milestone
future
Development

Successfully merging a pull request may close this issue.

Create units submodule zm711/python-neo
2 participants
@apdavison @zm711