Proof of concept of "buffer_description_api" and xarray reference API bridge #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
reviewed
Jul 26, 2024
| rfs = dict() | ||
| rfs["version"] = 1 | ||
| rfs["refs"] = dict() | ||
| rfs["refs"][".zgroup"] = json.dumps(dict(zarr_format=2)) |
There was a problem hiding this comment.
You don't need the dumps command anymore
neo/rawio/xarray_utils.py
Outdated
| chunk_size = array_size * dtype.itemsize | ||
| rfs["refs"][f"{stream_id}/0.0"] = [str(descr["file_path"]), descr["file_offset"], chunk_size] | ||
| rfs["refs"][f"{stream_id}/.zarray"] =json.dumps(zarray) | ||
| rfs["refs"][f"{stream_id}/.zattrs"] =json.dumps(zattrs) |
|
Looks good! |
…_buffer_description_api=True This should also solve the memmap and memmory leak problem.
…_buffer_description_api=True This should also solve the memmap and memmory leak problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the idea of @bendichter and this gist
Here a very very early stage of a very very proof of concept of the "buffer_description_api" for analogsignal chunk.
The idea/goal is:
See also kerchunk