Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell builder utility functions #107

Merged
merged 54 commits into from
Aug 31, 2022
Merged

Conversation

sanjayankur31
Copy link
Member

No description provided.

@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement S: ready for review Status: ready for review labels Jun 18, 2021
@sanjayankur31 sanjayankur31 self-assigned this Jun 18, 2021
@sanjayankur31 sanjayankur31 changed the title Feat/cell builder methods 105 Add cell builder utility functions Jun 19, 2021
@sanjayankur31 sanjayankur31 removed the S: ready for review Status: ready for review label Jun 24, 2021
@sanjayankur31
Copy link
Member Author

Not ready for review yet, got to move some of these to libNeuroML. Will do that after the current PR there has been merged, since this will require regenerating nml.py again

@sanjayankur31
Copy link
Member Author

tests need to be re-run after NeuralEnsemble/libNeuroML#105 has been merged and a new release made

@sanjayankur31 sanjayankur31 linked an issue Jul 8, 2021 that may be closed by this pull request
@sanjayankur31
Copy link
Member Author

I'll rebase this on development once #121 is merged to resolve the conflicts etc.

@sanjayankur31 sanjayankur31 marked this pull request as draft November 16, 2021 10:00
@sanjayankur31
Copy link
Member Author

@pgleeson I think this is now ready for review. I pulled in changes from the experimental branch too---it's just a refactored version of those now.

@shayanshafquat
Copy link
Contributor

shayanshafquat commented Jul 27, 2022

We can try adding a function that creates/adds a new segment group i.e. a subset of the existing segment groups and eventually adding it to the morphology of the cell. It can have utilities like adding inhomogeneous parameters as well.

@sanjayankur31
Copy link
Member Author

Suggestion: support for setting species for cell.biophysical_properties.intracellular_properties.species?

I've added a generic functions to add any intracellular/membrane properties now. How do these look?

@sanjayankur31
Copy link
Member Author

Note: needs NeuralEnsemble/libNeuroML#127 to be merged first, since that includes updates to the libNeuroML python API that are required here.

@pgleeson pgleeson merged commit 633452c into development Aug 31, 2022
@sanjayankur31 sanjayankur31 deleted the feat/cell-builder-methods-105 branch August 31, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: ready for review Status: ready for review T: enhancement Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper methods to build cells
4 participants