-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cell builder utility functions #107
Conversation
Not ready for review yet, got to move some of these to libNeuroML. Will do that after the current PR there has been merged, since this will require regenerating nml.py again |
tests need to be re-run after NeuralEnsemble/libNeuroML#105 has been merged and a new release made |
I'll rebase this on development once #121 is merged to resolve the conflicts etc. |
An omitted proximal point means that it is equal to the distal point of the parent segment
Segments will be added to these by default, for convenience
@pgleeson I think this is now ready for review. I pulled in changes from the experimental branch too---it's just a refactored version of those now. |
We can try adding a function that creates/adds a new segment group i.e. a subset of the existing segment groups and eventually adding it to the morphology of the cell. It can have utilities like adding inhomogeneous parameters as well. |
Different segments can have different resistivity, and we should be able to set them independently.
.. to match order in the ConductanceDensity constructor.
.. allows users to add all types of defined channel densities
If someone uses `iafcell`, we can't get `IafCell` from that without going through the whole libNeuroML nml module.
... to verify that channel density objects were added
[ci skip]
I've added a generic functions to add any intracellular/membrane properties now. How do these look? |
Note: needs NeuralEnsemble/libNeuroML#127 to be merged first, since that includes updates to the libNeuroML python API that are required here. |
No description provided.