Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "savedirtemp" generation option #540

Closed
wants to merge 5 commits into from

Conversation

lawrence-mbf
Copy link
Collaborator

Motivation

Related to #220, will close manually later. Instead of making temp dir default, allows for saving to temp directory as an extra flag.

How to test the behavior?

generateCore('savedirtemp');

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

- "savedirtemp" added to generateCore and generateExtension
- Updated help text for generateCore and generateExtension
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (a80f0aa) to head (71476d1).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
generateExtension.m 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   87.78%   87.78%   -0.01%     
==========================================
  Files         132      132              
  Lines        5626     5633       +7     
==========================================
+ Hits         4939     4945       +6     
- Misses        687      688       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lawrence-mbf lawrence-mbf marked this pull request as ready for review September 7, 2023 18:16
@bendichter bendichter closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants