Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

588 Add check on file export to ensure all required properties are filled out #600

Merged
merged 18 commits into from
Nov 2, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Sep 21, 2024

Fix #588

Motivation

Check that all required properties are filled out before nwb file is exported

How to test the behavior?

nwb=NwbFile();
nwbExport(nwb, 'test.nwb')

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad ehennestad marked this pull request as draft September 21, 2024 18:45
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.90%. Comparing base (5cd6af6) to head (99d8b42).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
+ Coverage   90.56%   90.90%   +0.34%     
==========================================
  Files         107      107              
  Lines        4695     4751      +56     
==========================================
+ Hits         4252     4319      +67     
+ Misses        443      432      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad marked this pull request as ready for review September 30, 2024 17:42
@ehennestad ehennestad marked this pull request as draft September 30, 2024 17:42
@ehennestad ehennestad marked this pull request as ready for review November 2, 2024 15:43
@ehennestad
Copy link
Collaborator Author

@bendichter Some fixes to the workflows from the previous PR got included here.

@ehennestad ehennestad merged commit 95b5e5e into master Nov 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Required NWBFile fields are not required by MatNWB
2 participants