propose changes to best practices #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cody Baker <[email protected]>
Co-authored-by: Cody Baker <[email protected]>
bendichter
added a commit
that referenced
this pull request
Aug 24, 2022
* Update dandi.inspector_config.yaml * enchanged * fix tests * remove unused lines * separate logic; cleanup * fix tests * Update nwbinspector/checks/nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * Update nwbinspector/checks/nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * Update tests/unit_tests/test_nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * Update tests/unit_tests/test_nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * update tests * Update tests/unit_tests/test_nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * Update tests/unit_tests/test_nwbfile_metadata.py Co-authored-by: Ben Dichter <[email protected]> * remove unused fields * propose changes to best practices (#252) * propose changes to best practices * Update docs/best_practices/nwbfile_metadata.rst Co-authored-by: Cody Baker <[email protected]> * Update docs/best_practices/nwbfile_metadata.rst Co-authored-by: Cody Baker <[email protected]> Co-authored-by: Cody Baker <[email protected]> * Include check_subject_proper_age_range to DANDI config (#255) * Update dandi.inspector_config.yaml * Update test_check_configuration.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Cody Baker <[email protected]> Co-authored-by: Cody Baker <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fix #209