-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in vitro support #431
Add in vitro support #431
Conversation
I would have chosen "shorter" and without any delimiters
but overall we simply cannot rely on any id there to carry semantic load -- it is merely an identifier primarily for a human consumption. Thus I would have been more specific in the identifier, e.g. |
If this link works: https://dandiarchive.slack.com/archives/GMRLT5RQ8/p1698938094950049?thread_ts=1698670803.322679&cid=GMRLT5RQ8 it should lead to the original discussion where the conclusion is to 'hack with some data elements'; the DANDI I agree that the proper solution is to (i) extend the consideration of a
So in this case, you would prefer |
the last famous words for a hack which became too popular at the end ;) yes -- it would take (bigger) effort but we should do that anyways looking forward
Yes, I think it is ok. |
Agreed; I would be happy to spearhead this going into the next cycle
Great, I made that change and added related docs Need further thoughts and/or approval from @bendichter @rly @oruebel to push this backdoor forward for the user |
I agree. Some in vitro data (most?) come from tissue slices from animals, so the normal |
We have gotten that before actually; a group wanted to upload electrode impedance measurements from a glass vial as a calibration/demonstration of device construction. Not that I'd say that's altogether super necessary data, or requires dandi infrastructure to share, but just saying it was requested previously |
I'm OK with this; @yarikoptic are you OK with |
sure - looks good to me. Ideally then whoever prepares BIDS dataset with this fills out some extra columns within |
@rly Swapped to "protein" |
Interesting. That makes sense. I guess these are both characterizations of sensors, so we could generalize the naming to "sensorX". But we have only two examples, and "proteinX" is nicely specific and would work. Best not to overthink this hack. |
Co-authored-by: Ryan Ly <[email protected]>
Motivation
From DANDI discussion: dandi/helpdesk#115 (comment) and ensuing internal Slack discussion with DANDI team from around that time...
There is a group wanting to upload NWB-formatted in vitro data to the archive; since so much of the current validation structure assumes in vivo, a workaround is needed to control certain requirements in this case
I propose that the simplest workaround is to specify the
subject_id
using the patternin_vitro_< some identifier >
; the NWB Inspector can then recognize this pattern and decide to automatically suppress certain nonsensical checks from being run, while allowing a human-readable filename ('sub-in-vitro-< some identifier >_ses-...') on the archive, making it obvious how the file content differs from the norm. As previously discussed, the existence of a 'participant'/'subject' and some ID for it is non-negotiable on the archive side since it's a core part of the metadata, and though the 'subject' of the in vitro experiments is merely a protein, that can still count to this effectIf this becomes more common, the better longer-term solution would likely be an extension of the core Subject data type specific to in vitro setups, but since they have already created their files this is currently a more costly solution
cc: @yarikoptic @satra @rly @oruebel @bendichter
If this sounds OK, I'll write some Best Practice docs on this PR and send instructions to the uploader on how to proceed from here