-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support only latest PyNWB #510
Conversation
TODO in follow-up: re-implement #265 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Added a couple comments/questions.
Co-authored-by: Steph Prince <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #510 +/- ##
==========================================
+ Coverage 79.53% 85.03% +5.50%
==========================================
Files 48 48
Lines 1412 1390 -22
==========================================
+ Hits 1123 1182 +59
+ Misses 289 208 -81
|
As per previous discussion about what range of support NWB Inspector ought to have with past PyNWB/HDMF versions - we decided it should only support latest
This simplifies a lot of conditions on the core inspection logic, individual checks, and what the testing suite is responsible for checking
The only aspect that cannot be replaced is using old versions of PyNWB to generate example files with particular failures that are no longer possible to achieve in latest PyNWB - these are still good to check the inspection logic on since someone could write a file using an older version but inspect it in a different environment (DANDI validate/upload would outright require that) - so I'm keeping those helpers around