Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate and test Zarr backend #513

Merged
merged 31 commits into from
Sep 27, 2024
Merged

Integrate and test Zarr backend #513

merged 31 commits into from
Sep 27, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

WIP Zarr integration

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 16, 2024
tests/test_inspector.py Outdated Show resolved Hide resolved
@CodyCBakerPhD CodyCBakerPhD linked an issue Sep 17, 2024 that may be closed by this pull request
2 tasks
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 25, 2024 21:45
@CodyCBakerPhD
Copy link
Collaborator Author

@stephprince Should be good to go, though I'd recommend looking at the others first

Discovered hdmf-dev/hdmf-zarr#220 and hdmf-dev/hdmf-zarr#221 as a result (hence the skipping of validations in the tests) but the Inspector side is good to go since it's a controllable behavior to enable/disable validation; but you will want to re-enable that in testing once those issues are resolved

Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments - otherwise looks good to me!

src/nwbinspector/tools/_read_nwbfile.py Outdated Show resolved Hide resolved
tests/test_inspector.py Outdated Show resolved Hide resolved
tests/test_inspector.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.16%. Comparing base (ea18bf6) to head (36421db).

Files with missing lines Patch % Lines
src/nwbinspector/_nwb_inspection.py 85.00% 3 Missing ⚠️
src/nwbinspector/tools/_read_nwbfile.py 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #513      +/-   ##
==========================================
+ Coverage   79.49%   86.16%   +6.66%     
==========================================
  Files          47       47              
  Lines        1390     1402      +12     
==========================================
+ Hits         1105     1208     +103     
+ Misses        285      194      -91     
Files with missing lines Coverage Δ
src/nwbinspector/_configuration.py 96.29% <100.00%> (+0.06%) ⬆️
src/nwbinspector/_registration.py 98.30% <100.00%> (+0.05%) ⬆️
src/nwbinspector/checks/_nwb_containers.py 97.43% <100.00%> (+1.00%) ⬆️
src/nwbinspector/tools/__init__.py 100.00% <100.00%> (ø)
src/nwbinspector/utils/_utils.py 91.96% <100.00%> (+0.07%) ⬆️
src/nwbinspector/tools/_read_nwbfile.py 79.68% <90.00%> (+59.99%) ⬆️
src/nwbinspector/_nwb_inspection.py 86.15% <85.00%> (+5.23%) ⬆️

... and 3 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 0a27c83 into dev Sep 27, 2024
38 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the integrate_zarr branch September 27, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support HDMF Zarr backend
4 participants