-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate and test Zarr backend #513
Conversation
for more information, see https://pre-commit.ci
@stephprince Should be good to go, though I'd recommend looking at the others first Discovered hdmf-dev/hdmf-zarr#220 and hdmf-dev/hdmf-zarr#221 as a result (hence the skipping of validations in the tests) but the Inspector side is good to go since it's a controllable behavior to enable/disable validation; but you will want to re-enable that in testing once those issues are resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a couple of comments - otherwise looks good to me!
Co-authored-by: Steph Prince <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #513 +/- ##
==========================================
+ Coverage 79.49% 86.16% +6.66%
==========================================
Files 47 47
Lines 1390 1402 +12
==========================================
+ Hits 1105 1208 +103
+ Misses 285 194 -91
|
WIP Zarr integration