Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import of Callable for typing #523

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Change import of Callable for typing #523

merged 2 commits into from
Oct 2, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 2, 2024

Motivation

Fix #522

@rly
Copy link
Contributor Author

rly commented Oct 2, 2024

Looks like something changed in the Windows runners or the conda action that is causing tests to fail. I'll quickly look into it.

@rly
Copy link
Contributor Author

rly commented Oct 2, 2024

I think the issue is due to conda being updated from 24.7.1 to 24.9.1 and the setup-conda action might be doing something weird with that. In any case, we can use setup-miniconda which we use elsewhere in NWB projects and is more widely used and maintained.

@rly rly requested a review from stephprince October 2, 2024 19:56
@rly rly enabled auto-merge (squash) October 2, 2024 19:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.83%. Comparing base (c453b68) to head (b217836).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #523      +/-   ##
==========================================
+ Coverage   82.77%   86.83%   +4.05%     
==========================================
  Files          47       47              
  Lines        1504     1504              
==========================================
+ Hits         1245     1306      +61     
+ Misses        259      198      -61     
Files with missing lines Coverage Δ
src/nwbinspector/_configuration.py 96.29% <100.00%> (ø)
src/nwbinspector/_registration.py 96.77% <100.00%> (ø)

... and 5 files with indirect coverage changes

@rly rly merged commit 007a4bd into dev Oct 2, 2024
37 of 38 checks passed
@rly rly deleted the typing_extensions branch October 2, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No module named 'typing_extensions'
3 participants