Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
epoch_tags
not written to disk #1901.epoch_tags
could be assigned in theNWBFile
constructor, but it was never written to disk. It could also be out of sync with the epochs table. It seems that it was maybe originally meant to be a shortcut for getting all of the unique epoch tags from theepochs
table.As a side effect of this change,
epoch_tags
would no longer be displayed by__repr__
or_repr_html_
(I looked a little into getting it to display, but if we include properties in the reprs it makes several other different datatype print outs less clean).See related discussion about deprecating here: #1521 (comment)
How to test the behavior?
Checklist
ruff check . && codespell
from the source directory.