Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug checking update of Bypass Paywalls Chrome Clean #59

Closed
Pointing8422 opened this issue Feb 20, 2021 · 1 comment
Closed

Bug checking update of Bypass Paywalls Chrome Clean #59

Pointing8422 opened this issue Feb 20, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Pointing8422
Copy link

Pointing8422 commented Feb 20, 2021

When I am checking for updates with the extension, always appear this error:
Bypass Paywalls Clean update failed.
This is the link of the extension: https://gitlab.com/magnolia1234/bypass-paywalls-chrome-clean
I also check the update.xml of this extension and it look fine: https://gitlab.com/magnolia1234/bypass-paywalls-chrome-clean/-/blob/master/updates.xml

@NeverDecaf
Copy link
Owner

This is caused by CORS blocking requests to external sites from within the extension (more details here).
The easy fix would be to add https://*/ to "permissions" in manifest.json, but this will grant and prompt users with a message about this app having access to Your data on all the websites you visit which I would like to avoid. I will add something more selective where the user can grant permissions for a specific site (when the update fails, most likely).

@NeverDecaf NeverDecaf added the bug Something isn't working label Feb 20, 2021
@NeverDecaf NeverDecaf self-assigned this Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants