feat(streams): Simple Load Balancing of Streams #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker Image for build 2 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
|
希望能把此pr能合并，正需要此功能 |
devon-thyne
reviewed
Sep 5, 2024
| @@ -167,7 +167,7 @@ | |||
| "add": "Add Stream", | |||
| "form-title": "{id, select, undefined{New} other{Edit}} Stream", | |||
| "incoming-port": "Incoming Port", | |||
| "forwarding-host": "Forward Host", | |||
| "forwarding-hosts": "Forward Hoss", | |||
There was a problem hiding this comment.
Suggested change
| "forwarding-hosts": "Forward Hoss", | |
| "forwarding-hosts": "Forward Hosts", |
|
Please merge it |
|
this would be great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to https://github.com/eedev - Their PR was marked stale: #1999
Motivation
I wanted to use Nginx Proxy Manager to do some simple load balancing for a EMQX cluster, seems I am not alone:
Description
I followed #1999 - unfortunately, that PR is very stale, so it was easier to branch off of upstream develop and re-implement the changes and perform the eslint fixes.
If your stream contains multiple upstreams - it will use the least connection strategy and max_fails=3
Alternative Approaches
A more robust solution would allow for specifying the upstream port for each of the forwarding hosts (upstreams). I did toy around with this but decided it was more work than I wanted to do right now and was worried it may break other user configurations.
Future Enhancements
Screenshots