Skip to content

Commit

Permalink
Tweak build settings
Browse files Browse the repository at this point in the history
  • Loading branch information
redsky17 committed Feb 8, 2019
1 parent 13663ad commit fa6bc6a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .ci/macos/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export ICU_LIB="$(brew --prefix icu4c)/lib"
mkdir -p nheko.app/Contents/Frameworks
find ${ICU_LIB} -type l -name "*.dylib" -exec cp -a -n {} nheko.app/Contents/Frameworks/ \; || true

sudo macdeployqt nheko.app -dmg
sudo macdeployqt nheko.app -dmg -always-overwrite

user=$(id -nu)
sudo chown ${user} nheko.dmg
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.11)

option(APPVEYOR_BUILD "Build on appveyor" OFF)
option(ASAN "Compile with address sanitizers" OFF)
Expand Down
7 changes: 6 additions & 1 deletion deps/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.1)
cmake_minimum_required(VERSION 3.11)
project(NHEKO_DEPS)

# Point CMake at any custom modules we may ship
Expand Down Expand Up @@ -30,6 +30,11 @@ option(USE_BUNDLED_LMDBXX "Use the bundled version of lmdbxx." ${USE_BUNDLED})
option(USE_BUNDLED_MATRIX_CLIENT "Use the bundled version of mtxclient."
${USE_BUNDLED})

if(USE_BUNDLED_BOOST)
# bundled boost is 1.68, which requires CMake 3.13 or greater.
cmake_minimum_required(VERSION 3.13)
endif()

include(ExternalProject)

set(BOOST_URL
Expand Down

1 comment on commit fa6bc6a

@redsky17
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should address the issues raised in #10, as well as fix the issues with the Mac .dmg files.

Please sign in to comment.