Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support editing messages #134

Closed
koalp opened this issue Mar 3, 2020 · 2 comments · Fixed by #420
Closed

Support editing messages #134

koalp opened this issue Mar 3, 2020 · 2 comments · Fixed by #420
Labels
enhancement New feature or request

Comments

@koalp
Copy link

koalp commented Mar 3, 2020

Currently, we cannot edit messages in nheko, but we can in riot.

It would be nice to be able to edit messages

@koalp koalp added the enhancement New feature or request label Mar 3, 2020
@deepbluev7
Copy link
Member

Yes, this would be nice to have. Since we have other priorities right now, we actually listed that as one of the possible GSoC projects. This also isn't currently in the official Matrix Spec. The proposal for it is still in review: matrix-org/matrix-spec-proposals#1849

Since no client actually implements, what is stated in that proposal, but uses different names for the relations etc, we would have to reverse engineer, what other clients do... So I'd rather wait for the official spec in this case. If someone is interested in implementing that, I would be willing to help out anytime though!

@deepbluev7 deepbluev7 changed the title message edition Support editing messages Mar 4, 2020
@artemislena
Copy link

Another nice feature to have, that would set Nheko apart from competitors, is sed-style regex replace (as in s/original/edit/g). Having some / command for this, that somehow offers an option to specify the message one wants to edit (for example by adding 2 to select the messsage one sent 2 messages before the last one), while perhaps defaulting to the last one (0 in my example) sent by that user, would be quite nice.

deepbluev7 added a commit that referenced this issue Feb 1, 2021
The UI still looks ugly, but I have no good idea atm.

fixes #134
deepbluev7 added a commit that referenced this issue Feb 9, 2021
The UI still looks ugly, but I have no good idea atm.

fixes #134
Lymkwi pushed a commit to Lymkwi/nheko that referenced this issue May 1, 2024
Lymkwi pushed a commit to Lymkwi/nheko that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants