Make the image overlay behave better #1643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenDB
force-pushed
the
betterimageview
branch
from
01fef9e
to
5908353
Compare
deepbluev7
reviewed
Jan 6, 2024
LorenDB
force-pushed
the
betterimageview
branch
2 times, most recently
from
5bdd6d7
to
1948ef0
Compare
|
FWIW, I originally tried to clamp the image edges to the screen edge if the image was zoomed in to be larger than the screen in at least one dimension, but it kept acting buggy, so I gave up on that. |
LorenDB
force-pushed
the
betterimageview
branch
from
1948ef0
to
879710b
Compare
deepbluev7
reviewed
Feb 14, 2024
Comment on lines
147
to
148
| xAxis.enabled: imgContainer.physicalWidth > Screen.width | ||
| yAxis.enabled: imgContainer.physicalHeight > Screen.height |
There was a problem hiding this comment.
Shouldn't we be comparing against the window size here in case some compositor ignores our full screen request?
|
Seems to work well with a mouse, still need to test it on my touchpad :D |
Previously, the image would not try to stay centered; furthermore, on mobile devices, it was impossible to zoom images without dropping them at a slightly off rotation. This bothered me enough that I've clamped images to the center of the screen (as long as they aren't zoomed larger than the screen) and snapped rotations to 45-degree increments (with a nice animation to boot).
LorenDB
force-pushed
the
betterimageview
branch
from
879710b
to
52346d9
Compare
|
Hm, does anybody remember, why I hadn't merged that yet? Just because I didn't test it with my touchpad yet? Or because the rotation snapping didn't work? |
|
I think just the touchpad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the image would not try to stay centered; furthermore,
on mobile devices, it was impossible to zoom images without dropping
them at a slightly off rotation. This bothered me enough that I've
clamped images to the center of the screen (as long as they aren't
zoomed larger than the screen) and snapped rotations to 45-degree
increments (with a nice animation to boot).