Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: updating explorer to latest ping-pub #3

Merged
merged 17 commits into from
Nov 8, 2023
Merged

feat: updating explorer to latest ping-pub #3

merged 17 commits into from
Nov 8, 2023

Conversation

CalicoNino
Copy link

@CalicoNino CalicoNino commented Oct 24, 2023 •
edited
Loading

@CalicoNino CalicoNino added the enhancement New feature or request label Oct 24, 2023
@CalicoNino CalicoNino self-assigned this Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 10618a3):

https://nibiru-explorer--pr3-chore-latest-ping-pu-4dp2mvm7.web.app

(expires Tue, 21 Nov 2023 15:40:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0653a911498be5ff7b1517207d84ddca0bcce10b

@CalicoNino CalicoNino marked this pull request as draft October 29, 2023 17:37
@CalicoNino CalicoNino marked this pull request as ready for review October 29, 2023 18:54
@cgilbe27
Copy link

cgilbe27 commented Nov 7, 2023

Update links to be consistent with whats in prod:
image
image

@cgilbe27
Copy link

cgilbe27 commented Nov 7, 2023

Also potentially convert these links to branded links as well

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CalicoNino CalicoNino merged commit d3ad95d into master Nov 8, 2023
4 checks passed
@CalicoNino CalicoNino deleted the chore/latest-ping-pub branch November 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgilbe27 cgilbe27 cgilbe27 approved these changes

@k-yang k-yang Awaiting requested review from k-yang

@Unique-Divine Unique-Divine Awaiting requested review from Unique-Divine

Assignees

@CalicoNino CalicoNino

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CalicoNino @cgilbe27