Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close main window on first quit on all platforms #661

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix: close main window on first quit on all platforms #661

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3891e5b
fix: tray window closed on first app quit
jgresham Sep 16, 2024
0bebf6a
fix: close main window on first quit cleanup
jgresham Sep 16, 2024
eec44f7
Merge branch 'main' into fix/tray-window-error
jgresham Sep 16, 2024
2bda9f3
cleanup
jgresham Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,8 @@ app.on('before-quit', (e) => {
// monitor node's statuses and alert the user when a node is down, and to continuously
// track node usage.
e.preventDefault(); // halts electron's full quitting action
// todo: close windows?
mainWindow?.close(); // close the main window
if (process.platform === 'darwin' && app.dock) {
mainWindow?.close(); // close the main window
app.dock.hide(); // app appears "quitted" in the dock
}
}
Expand Down