Delete feature flag enable_crash_on_missing_component_descriptor

Summary: changelog: [internal] Clean up unused feature flag Reviewed By: fkgozali Differential Revision: D42709724 fbshipit-source-id: a124015783983dea28db31a4431183f5c30a30e7
NickGerleman · Jan 25, 2023 · 8863be4 · 8863be4
1 parent 51c03a0
commit 8863be4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 28 deletions.
diff --git a/React/Fabric/RCTScheduler.mm b/React/Fabric/RCTScheduler.mm
@@ -115,9 +115,7 @@ - (instancetype)initWithToolbox:(SchedulerToolbox)toolbox
       _layoutAnimationDelegateProxy = std::make_shared<LayoutAnimationDelegateProxy>((__bridge void *)self);
       _animationDriver = std::make_shared<LayoutAnimationDriver>(
           toolbox.runtimeExecutor, toolbox.contextContainer, _layoutAnimationDelegateProxy.get());
-      if (reactNativeConfig->getBool("react_fabric:enable_crash_on_missing_component_descriptor")) {
-        _animationDriver->enableCrashOnMissingComponentDescriptor();
-      }
+
       if (reactNativeConfig->getBool("react_fabric:enable_simulate_image_props_memory_access")) {
         _animationDriver->enableSimulateImagePropsMemoryAccess();
       }

diff --git a/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp b/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.cpp
@@ -1108,10 +1108,6 @@ void LayoutAnimationKeyFrameManager::setClockNow(
   now_ = std::move(now);
 }
 
-void LayoutAnimationKeyFrameManager::enableCrashOnMissingComponentDescriptor() {
-  crashOnMissingComponentDescriptor_ = true;
-}
-
 void LayoutAnimationKeyFrameManager::enableSimulateImagePropsMemoryAccess() {
   simulateImagePropsMemoryAccess_ = true;
 }
@@ -1120,18 +1116,8 @@ void LayoutAnimationKeyFrameManager::enableSimulateImagePropsMemoryAccess() {
 
 bool LayoutAnimationKeyFrameManager::hasComponentDescriptorForShadowView(
     ShadowView const &shadowView) const {
-  auto hasComponentDescriptor =
-      componentDescriptorRegistry_->hasComponentDescriptorAt(
-          shadowView.componentHandle);
-
-  if (crashOnMissingComponentDescriptor_ && !hasComponentDescriptor) {
-    LOG(FATAL) << "Component descriptor with handle: "
-               << shadowView.componentHandle
-               << " doesn't exist. The component name: "
-               << shadowView.componentName;
-  }
-
-  return hasComponentDescriptor;
+  return componentDescriptorRegistry_->hasComponentDescriptorAt(
+      shadowView.componentHandle);
 }
 
 ComponentDescriptor const &

diff --git a/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h b/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h
@@ -90,8 +90,6 @@ class LayoutAnimationKeyFrameManager : public UIManagerAnimationDelegate,
 
   void setClockNow(std::function<uint64_t()> now);
 
-  void enableCrashOnMissingComponentDescriptor();
-
   void enableSimulateImagePropsMemoryAccess();
 
  protected:
@@ -152,13 +150,6 @@ class LayoutAnimationKeyFrameManager : public UIManagerAnimationDelegate,
   mutable butter::set<SurfaceId> surfaceIdsToStop_{};
   bool reduceDeleteCreateMutation_{false};
 
-  /*
-   * Feature flag that forces a crash if component descriptor for shadow view
-   * doesn't exist. This is an unexpected state and we crash to collect extra
-   * logs.
-   */
-  bool crashOnMissingComponentDescriptor_{false};
-
   /*
    * Feature flag that enables simulation of memory access. This is a temporary
    * flag to diagnose where crashes are coming from in LayoutAnimations on iOS.