New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formSelect to handle hidden prop #1

Merged

NickGuyver merged 4 commits into NickGuyver:custom-analog-error-rate from Pelsin:custom-analog-error-rate

Sep 15, 2024

Pelsin commented Sep 15, 2024 •

edited

Loading

Converted the formSelect to typeScript.
Added types for label that was giving errors before.
Now possible to send hidden as a property.
Fixed a tiny issue in focusMode addon that was giving warnings in the console.
Changed the order of the checkbox so they don't break the rows unevenly

Pelsin added 4 commits

September 15, 2024 21:29


          Convert FormSelect to ts, add types for label. add support for hiding…

beeeaee

… with prop


          Reorder checkboxes for better flow


          Fix key error for focus mode

1f9ddd7


          Remove logging used to check values

9177d9a

NickGuyver merged commit c4d088f into NickGuyver:custom-analog-error-rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet