player-calcs: use updated flags rather than flags from prior state #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backwardsEric
added a commit
to backwardsEric/angband
that referenced
this pull request
Jan 18, 2024
Ported from NickMcConnell/FAangband#407 . There should be no observable change to what the player experiences (all the tested flags are tied to the player's class, calc_bonuses() is called at least twice after starting/loading a game before the player can act, and for the affected calculations there's no hysteresis with the old versions of the calculations if they happen to use potentially stale versions of the flags).
|
Thank you |
NickMcConnell
pushed a commit
to angband/angband
that referenced
this pull request
Jan 18, 2024
Ported from NickMcConnell/FAangband#407 . There should be no observable change to what the player experiences (all the tested flags are tied to the player's class, calc_bonuses() is called at least twice after starting/loading a game before the player can act, and for the affected calculations there's no hysteresis with the old versions of the calculations if they happen to use potentially stale versions of the flags).
agoodman00
pushed a commit
to agoodman00/angband
that referenced
this pull request
Jan 19, 2024
Ported from NickMcConnell/FAangband#407 . There should be no observable change to what the player experiences (all the tested flags are tied to the player's class, calc_bonuses() is called at least twice after starting/loading a game before the player can act, and for the affected calculations there's no hysteresis with the old versions of the calculations if they happen to use potentially stale versions of the flags).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #406 .