V3 #21
Merged
V3 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #13, fixes #14, fixes #19 Adds directory minimizing/maximizing, without moving into them, by putting the content below it. Adds file/directory renaming, creation, & deletion. Changes to read-only so you can't mess with the tree. Changes some keybindings to work safely with the tree view. Disable most keybindings that normally cause issues.
Fixes #15
Removed the png, will replace it with a gif in the future
I think it works without them, but it's better to be verbose.
|
Looks good but there is a problem with the left mouse clicking on long lists. (does not open or opens the wrong filename.) Needs looking in to. |
|
@tommyshem The exact issue is here https://github.com/sum01/filemanager-plugin/issues/8 |
Uses a new function in micro-1.3.5-dev.67
|
The mouseclick issue is fixed. |
|
@NicolaiSoeborg Can be pulled in if you are happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I completely understand if you don't want to merge this, as I basically rewrote the whole thing.
Note that while this PR requires Micro >= v1.3.5, I kept the old version in the
repo.jsonso that people not on v1.3.5 can still use the previous version.Anyways, this PR brings:
Fixes
Adds
Changes
Enterkeybind was changed toTabbecause read-only disables the enter key.Removed
I'm aware there's some dead code, and other little general weirdness, but I figure that for the most part my branch is finished. Sure things could be more clean and whatnot, but something > nothing.